bitstorm commented on code in PR #1072:
URL: https://github.com/apache/wicket/pull/1072#discussion_r1909050624


##########
wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java:
##########
@@ -615,6 +633,14 @@ public String toString()
                                
str.append('[').append(entry.getValue()).append(']');
                        }
                }
+
+               if (str.length() > 0)
+               {
+                       str.append(", ");
+               }
+
+               
str.append("fragment=").append('\'').append(fragment).append('\'');

Review Comment:
   I would say to avoid printing anything if fragment is null  to maintain 
consistency with the rest of the toString code. I fill add a null pointer 
check. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to