theigl commented on PR #1076: URL: https://github.com/apache/wicket/pull/1076#issuecomment-2597729301
> > Let's take a step back and think about this once again. > > ``` > > 1. The original behavior prior to your PR [WICKET-7123 default form submit can now be set one per form #971](https://github.com/apache/wicket/pull/971) was that forms could not be submitted via ENTER from multiline fields. This is what I would consider "default" browser behavior. > > ``` > > No. Original problem was that in form hierarchy (eg. parent form with some field and containing another form with more fields), default submit is always executed on last form rendered on page - which is obviously incorrect, and this limitation was also mentioned in docs - see comment here [Form.java](https://github.com/apache/wicket/blob/783722121d55530813f21e5e6bc14e9955777e5c/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L505). I wanted to improve it with a little bit of javascript - remove limitation on form hierarchy. Sorry I wasn't very clear. All your other changes are good as far as I can tell. I'm only talking about how the ENTER key behaved before and after your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
