theigl commented on PR #1093: URL: https://github.com/apache/wicket/pull/1093#issuecomment-2647445512
I thought about this some more over the weekend: It took me about 30 hours to fully annotate our ~350KLOC codebase by using the approach described above. Wicket is much smaller than that and we probably only need to annotate the most important packages in `wicket-core` and `wicket-request` to get immediate benefits for Kotlin users. I would suggest the following approach: 1. Create a PR that adds JSpecify but does not annotate anything and merge it 2. Create PRs that annotate a single package or a small group of packages with `@NullMarked` and `@Nullable` That way individual PRs should be relatively small and easy to review and by using only `@Nullable` the noise should be kept to a minimum. Ideally, these changes would be driven by someone who actually uses Wicket with Kotlin and can verify the improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
