[
https://issues.apache.org/jira/browse/WICKET-7152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938831#comment-17938831
]
ASF GitHub Bot commented on WICKET-7152:
----------------------------------------
martin-g commented on code in PR #1133:
URL: https://github.com/apache/wicket/pull/1133#discussion_r2015832446
##########
wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java:
##########
@@ -142,7 +148,7 @@ else if (mode == Mode.STATUS)
setStatus(response, requestCycle, location);
}
// Mode.AUTO
- else if (status == HttpServletResponse.SC_MOVED_TEMPORARILY)
+ else if (status == HttpServletResponse.SC_FOUND)
Review Comment:
Why is this being changed ?
##########
wicket-request/pom.xml:
##########
@@ -38,5 +38,11 @@
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-util</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <scope>test</scope>
Review Comment:
The `scope` should be defined in the `dependencyManagement` section in the
parent pom.
> Extend RedirectRequestHandler for statusCodes 307 and 308
> ---------------------------------------------------------
>
> Key: WICKET-7152
> URL: https://issues.apache.org/jira/browse/WICKET-7152
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Affects Versions: 10.4.0
> Reporter: Hans Schäfer
> Priority: Minor
>
> RedirectRequestHandler only accepts status 301, 302 and 303. Should also work
> for other status codes 307 and 308.
> 308 makes the browser use the same HTTP-Method. So if a browser sends a
> POST-Request and receives a 308-Response, then the browser will repost for
> the changed location. I need this behavior for supporting an endpoint used by
> another company. My workaround until now is an Apache-Rule doing the job now.
> Note: If it was a 302 the browser would change the method to "GET".
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
