martin-g commented on code in PR #1087:
URL: https://github.com/apache/wicket/pull/1087#discussion_r2380941692
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1288,15 +1292,66 @@ protected void
addDefaultSubmitButtonHandler(IHeaderResponse headerResponse)
headerResponse.render(OnEventHeaderItem.forMarkupId(getMarkupId(), "keypress",
script.toString()));
}
+
Review Comment:
```suggestion
```
##########
wicket-core-tests/src/test/java/org/apache/wicket/markup/html/form/FormVisitTest.java:
##########
@@ -355,6 +393,32 @@ public void updateFormComponentModelsInPostorder()
assertTrue(page.innerField.updateModelOrder <
page.outerField.updateModelOrder);
}
+ @Test
+ public void callInnerFormOnAfterUpdateFormComponentModels()
+ {
+ tester.newFormTester("outerForm").submit();
+
+
assertTrue(page.innerForm.onAfterUpdateFormComponentModelsCalled);
+ }
+
+ @Test
+ public void dontCallInnerFormOnAfterUpdateFormComponentModels()
+ {
+ page.innerForm.wantSubmitOnParentFormSubmit = false;
+ tester.newFormTester("outerForm").submit();
+
+
assertFalse(page.innerForm.onAfterUpdateFormComponentModelsCalled);
+ }
+
+ @Test
+ public void callFormOnAfterUpdateFormComponentModelsInPostorder()
Review Comment:
```suggestion
public void callFormOnAfterUpdateFormComponentModelsInPostOrder()
```
##########
wicket-core-tests/src/test/java/org/apache/wicket/markup/html/form/FormVisitTest.java:
##########
@@ -329,6 +341,32 @@ public void validateFormComponentsInPostorder()
assertTrue(page.innerField.onValidCallOrder <
page.outerField.onValidCallOrder);
}
+
+ @Test
+ public void callInnerFormOnBeforeUpdateFormComponentModels()
+ {
+ tester.newFormTester("outerForm").submit();
+
+
assertTrue(page.innerForm.onBeforeUpdateFormComponentModelsCalled);
+ }
+
+ @Test
+ public void dontCallInnerFormOnBeforeUpdateFormComponentModels()
+ {
+ page.innerForm.wantSubmitOnParentFormSubmit = false;
+ tester.newFormTester("outerForm").submit();
+
+
assertFalse(page.innerForm.onBeforeUpdateFormComponentModelsCalled);
+ }
+
+ @Test
+ public void callFormOnBeforeUpdateFormComponentModelsInPostorder()
Review Comment:
```suggestion
public void callFormOnBeforeUpdateFormComponentModelsInPostOrder()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
