[ 
https://issues.apache.org/jira/browse/WICKET-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030802#comment-18030802
 ] 

ASF GitHub Bot commented on WICKET-7090:
----------------------------------------

bgooren commented on PR #1278:
URL: https://github.com/apache/wicket/pull/1278#issuecomment-3417956356

   > @bgooren the bundle plugin (by default) includes resources from the 
'source' location of resources (src/main/resources, etc) and needed a hint to 
pull in resources post-processing (target/classes)
   
   Hi! I saw that and it makes sense. But one question is still unanswered: it 
was already pulling in the other min.js files prior to your change, which are 
generated using the exact same plugin as the missing file, and written to the 
same location. So why was that one file excluded when the rest was already 
included?
   The only hunch I have is that perhaps it is because all the other 
post-processed js files are next to components, and the wicket-ajax-jquery.js 
(and min.js) are not.




> Files in release jars do not have a modification timestamp set
> --------------------------------------------------------------
>
>                 Key: WICKET-7090
>                 URL: https://issues.apache.org/jira/browse/WICKET-7090
>             Project: Wicket
>          Issue Type: Bug
>          Components: release
>    Affects Versions: 9.8.0, 9.9.0, 9.10.0, 9.11.0, 9.12.0, 9.13.0, 9.14.0, 
> 9.15.0, 9.16.0
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Minor
>             Fix For: 10.0.0
>
>
> Starting with 9.8.0, the release jars are built with file entries without a 
> last modification timestamp. This can cause issues if 
> {{LastModifiedResourceVersion}} used for the {{{}resourceCachingStrategy{}}}. 
> The browser may be using an older version of the resource, even if a newer 
> version is available. This strategy is normally only used in development 
> mode, but even then this can cause unexpected behavior.
> As discussed on the dev list, the best we can do is to set the last 
> modification timestamp to fixed time during the release, as git doesn't track 
> this. A suggestion is to useĀ  the project.build.outputTimestamp property: 
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to