martin-g commented on PR #1310: URL: https://github.com/apache/wicket/pull/1310#issuecomment-3581467519
Well, my experience is the opposite: restructuring and bugfix/feature impl should not be mixed in the same Pull Request! Even worse in the same commit! This way the bugfix/feature is hidden in a lot of noise (the restructuring). It is not clear whether the bugfix/feature does not break some previous behavior because now the old tests are reworked too. Even though the intention was to improve them there is a chance that they were actually broken. I am grateful for your contribution but I won't review it in its current state. Hopefully someone else from the team will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
