[ 
https://issues.apache.org/jira/browse/WICKET-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041155#comment-18041155
 ] 

ASF subversion and git services commented on WICKET-7170:
---------------------------------------------------------

Commit 154373e5b2f5d5524596300d6dc031757e07b7a4 in wicket's branch 
refs/heads/master from Hans Schäfer
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=154373e5b2 ]

WICKET-7170: AnnotProxyFieldValueFactory now considers defaultCandidate (#1311)

* WICKET-7170: AnnotProxyFieldValueFactory now considers defaultCandidate-Flag

* Reset tests to focus only on implementation / bugfix

* Added test for DefaultCandidate-Scenario

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java

Co-authored-by: Martin Grigorov <[email protected]>

* Update 
wicket-spring/src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java

Co-authored-by: Martin Grigorov <[email protected]>

---------

Co-authored-by: Schäfer, H.H. (Hans Hosea) <[email protected]>
Co-authored-by: Martin Grigorov <[email protected]>

> SpringInjector / AnnotProxyFieldValueFactory does not consider 
> defaultCandidate
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-7170
>                 URL: https://issues.apache.org/jira/browse/WICKET-7170
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-spring
>    Affects Versions: 10.7.0
>            Reporter: Hans Schäfer
>            Priority: Major
>
> Spring considers the defaultCandidate-Flag, supplementary to the 
> autowireCandidate-Flag. This ist currently not supported by SpringInjector / 
> AnnotProxyFieldValueFactory.
> Assume 2 Beans of the same Class / Type: one is autowiredCandidate=true / 
> defaultCandidate=true, the second is autowireCandidate=true but 
> defaultCandidate = false.
> Spring always chosses the first one for autowiring, if no explicit beanName 
> is given.
> Wicket complains about 2 beans of same type.
> Spring had a similar issue when creating proxies for beans with 
> defaultCandidate = false:
> [https://github.com/spring-projects/spring-framework/issues/35626]
> There is a Pull Request that fixes this issue: 
> [https://github.com/apache/wicket/pull/1310]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to