martin-g commented on code in PR #1383:
URL: https://github.com/apache/wicket/pull/1383#discussion_r2842807783
##########
wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java:
##########
@@ -286,14 +286,19 @@ protected AbstractFileUpload newFileUpload(String
encoding) {
fileUpload.setHeaderCharset(charset);
}
- fileUpload.setSizeMax(getMaxSize().bytes());
+ fileUpload.setMaxSize(getMaxSize().bytes());
Bytes fileMaxSize = getFileMaxSize();
- if (fileMaxSize != null) {
- fileUpload.setFileSizeMax(fileMaxSize.bytes());
+
+ if (fileMaxSize != null)
+ {
+ fileUpload.setMaxFileSize(fileMaxSize.bytes());
}
- fileUpload.setFileCountMax(getFileCountMax());
+ fileUpload.setMaxFileCount(getFileCountMax());
+
+ fileUpload.setMaxPartHeaderSize(
+
Application.get().getApplicationSettings().getDefaultMaximumPartHeaderSize());
Review Comment:
Let's also add a `protected int getDefaultMaximumPartHeaderSize() { return
Application.get().getApplicationSettings().getDefaultMaximumPartHeaderSize();
}` and use it here.
Same as the other getters above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
