martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3145189270
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
The idea is that the JS tests could be reused to test with any version of
jQuery.
http://localhost:8080/ajax-tests/test/js/all.html?4.0.0 will test with
jQuery 4.0.0
http://localhost:8080/ajax-tests/test/js/all.html?3.7.1 will test with
jQuery 3.7.1
AFAIR `var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";` is
checking which major version of jQuery is in use. Both 4.x and 3.x should use
`%20` as a space in urls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
