lalmeras opened a new pull request, #1485: URL: https://github.com/apache/wicket/pull/1485
FileCleaningTrackerAdapter does not delegate some calls to IFileCleaner. These call are then performed by FileCleaningTracker superclass. Each FileCleaningTrackerAdapter then create a Reaper thread that is leaked (FileCleaningTrackerAdapter is request-scope). Intended behavior is to delegate to IFileCleaner that is a singleton (there is at most 1 Reaper by wicket application). The issue appears on wicket 10.9.x as commons-fileupload2-M5 refactors DiskFileItem and now calls the Path variant of track(...) method. This fix adds the missing delegate methods. --- I successfully tested this fix on wicket-10.x branch with one of our application and a breakpoint on `FileCleaningTracker$Reaper`. Before fix, one Reaper is created for each file upload. After fix, Reaper is created only on the first call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
