jstuyts opened a new pull request, #1498: URL: https://github.com/apache/wicket/pull/1498
Added type to JavaScript content header items, and added a JavaScript import map header item. The first attempt was to make a base class for `AbstractJavaScriptReferenceHeaderItem` and `JavaScriptContentHeaderItem`, and move the type to there. But `setType(...)` in the former returns `AbstractJavaScriptReferenceHeaderItem`. Moving the type information up the hierarchy would break backward compatibility. The (simple) code for managing the type has simply been copied now. `JavaScriptReferenceType` should be called `JavaScriptType` now, but that would also break backward compatibility. This has been documented. If the new features are not used, almost everything works as before. The only change to current behavior is that `equals(...)` and `hashCode(...)` of `JavaScriptContentHeaderItem` now also use the type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
