papegaaij commented on PR #564: URL: https://github.com/apache/wicket/pull/564#issuecomment-5933317396
Thank you for the contribution, and sorry it sat for so long. I'm closing this PR. The discussion never agreed that this belongs in `MarkupFactory` rather than in a shared `MarkupFactory` subclass, and it stalled after that counter-proposal. There is also a design problem. Every `MarkupParser` shares the registered `IMarkupFilter` instances, but a markup filter holds per-parse state: the resource stream it was created for, and its place in the filter chain set through `setNextFilter`. Concurrent or successive parses would therefore interfere with each other. A working version would have to register a factory that creates a fresh filter for each parser. New features would also go to master first rather than to `wicket-9.x`. If you don't agree, please reopen it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
