reiern70 commented on PR #1634: URL: https://github.com/apache/wicket/pull/1634#issuecomment-5956331383
@papegaaij thanks for the review. d531d49aa8 adds the cases from your comments to the examples, so each fix can be tried out: - **Host replaced while veiled**: in `websockets/veil` the long rounds push a progress update halfway through, which redraws the panel while it stays veiled. The Ajax-only variant can't be shown: the page lock serializes requests to the same page, so another request can't re-render the host while the first one runs. - **Unmatched `hide()`**: `websockets/veil` has a link that sends a slow Ajax request from the panel, while the server sends an unveil message that no veil message preceded. The panel stays veiled until the request is done. - **Delegated behavior (`attrs.sel`)**: `ajax/veil`, "Delegated clicks". One `AjaxEventBehavior` on the list handles its rows through a child selector, and only the row that was clicked is veiled. - **Markup ids like `constructor`**: `ajax/veil`, a panel whose markup id is `constructor`. - **Scrolling host**: `ajax/veil`, a scrolling box. The veil covers the visible part and follows the box while it scrolls. - **Positioned host**: `ajax/veil`, an absolutely positioned card that stays in place while veiled. - **Stacking (`isolation`)**: `ajax/veil`, a panel under a sticky header. The veil stays behind the header. - **`Locale.ROOT`**: not visible in an example; `VeilBehaviorTest` covers it under `th-TH-u-nu-thai`. - **Redirect**: reverted in f0fca0d5f7, as you asked. `VeilPageSeleniumTest` drives each `ajax/veil` case in headless Chrome with both Ajax engines (`-Dwicket.selenium=true`). The WebSocket cases were checked by hand, since the test Jetty has no WebSocket support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
