martin-g commented on PR #1557: URL: https://github.com/apache/wicket/pull/1557#issuecomment-6058458719
Thanks for your quick response, @timtebeek ! Open-Rewrite is a cool idea but the decisions taken and the implementation is not good! So, OSS modules depend on paid ones and the users have to figure it out... I've added exclusions for the problematic modules and now the build fails with dependency convergence errors: ``` [ERROR] Rule 1: org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with message: [ERROR] Failed while enforcing releasability. [ERROR] [ERROR] Dependency convergence error for org.jetbrains.kotlin:kotlin-reflect:jar:1.6.10. Paths to dependency are: [ERROR] +-org.apache.wicket:wicket-migration:jar:11.0.0-SNAPSHOT [ERROR] +-org.openrewrite.recipe:rewrite-migrate-java:jar:3.26.0:compile [ERROR] +-org.openrewrite:rewrite-gradle:jar:8.91.0:runtime [ERROR] +-org.openrewrite:rewrite-kotlin:jar:8.91.0:runtime [ERROR] +-org.jetbrains.kotlin:kotlin-compiler-embeddable:jar:2.4.10:runtime [ERROR] +-org.jetbrains.kotlin:kotlin-reflect:jar:1.6.10:runtime [ERROR] and [ERROR] +-org.apache.wicket:wicket-migration:jar:11.0.0-SNAPSHOT [ERROR] +-org.openrewrite.recipe:rewrite-migrate-java:jar:3.26.0:compile [ERROR] +-org.openrewrite:rewrite-gradle:jar:8.91.0:runtime [ERROR] +-org.openrewrite:rewrite-kotlin:jar:8.91.0:runtime [ERROR] +-org.jetbrains.kotlin:kotlin-reflect:jar:2.4.10:runtime [ERROR] [ERROR] [ERROR] Dependency convergence error for org.jspecify:jspecify:jar:1.0.1. Paths to dependency are: [ERROR] +-org.apache.wicket:wicket-migration:jar:11.0.0-SNAPSHOT [ERROR] +-org.openrewrite.recipe:rewrite-migrate-java:jar:3.26.0:compile [ERROR] +-org.openrewrite:rewrite-java:jar:8.91.0:runtime [ERROR] +-org.openrewrite:rewrite-core:jar:8.91.0:runtime [ERROR] +-org.jspecify:jspecify:jar:1.0.1:runtime [ERROR] and [ERROR] +-org.apache.wicket:wicket-migration:jar:11.0.0-SNAPSHOT [ERROR] +-org.openrewrite.recipe:rewrite-migrate-java:jar:3.26.0:compile [ERROR] +-org.openrewrite:rewrite-java:jar:8.91.0:runtime [ERROR] +-io.micrometer:micrometer-core:jar:1.17.0:test [ERROR] +-org.jspecify:jspecify:jar:1.0.0:test [ERROR] and [ERROR] +-org.apache.wicket:wicket-migration:jar:11.0.0-SNAPSHOT [ERROR] +-org.openrewrite.recipe:rewrite-migrate-java:jar:3.26.0:compile [ERROR] +-org.openrewrite:rewrite-java:jar:8.91.0:runtime [ERROR] +-io.micrometer:micrometer-core:jar:1.17.0:test [ERROR] +-io.micrometer:micrometer-commons:jar:1.17.0:test [ERROR] +-org.jspecify:jspecify:jar:1.0.0:test ... ``` This has always been a pain with openrewrite updates in Wicket. Lately a LLM agent does pretty good job in helping with migrations, so based on the problems above my opinion is that wicket-migration module should be removed for Wicket 11 and documented as deprecated for Wicket 10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
