17krishna8 commented on PR #1673: URL: https://github.com/apache/wicket/pull/1673#issuecomment-6229813026
@mattrpav agreed, the fallback was the wrong call - `Url.parse()` keeps failing fast, and the request now gets a 400 instead. @reiern70 thanks for the detailed review and the sketch. I have reworked the PR: `Url.parse()` is unchanged and now documents that it throws `NumberFormatException` for a port that is not a number, and `ServletWebRequest.getClientUrl()` answers a base url that cannot be parsed with the same 400 a missing one already gets, with your `getClientUrlAjaxWithMalformedBaseUrl` test next to `getClientUrlAjaxWithoutBaseUrl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
