17krishna8 commented on PR #1674:
URL: https://github.com/apache/wicket/pull/1674#issuecomment-6229813321
Thanks for walking me through what actually happens after the constructor -
I had stopped too early. I did not know about `WebSocketResourcePage`.
I have reworked the change: the handshake still fails when `pageId` is not a
number, but the constructor now throws `IllegalArgumentException("Request
parameter 'pageId' must be a number")` instead of the bare
`NumberFormatException`, and the test asserts the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
