archiforge opened a new pull request, #1686: URL: https://github.com/apache/wicket/pull/1686
This back-ports the `XsltTransformer` hardening from master (348725cf, PR #1537) to the 9.x line, as requested in WICKET-7201. - `XsltTransformer.transform()` now enables `XMLConstants.FEATURE_SECURE_PROCESSING` on its `TransformerFactory`, matching `XSLTResourceStream` on this line. - Adds the upstream XXE regression test (JUnit 5) to `wicket-core`. - Does not set `accessExternalDTD`/`accessExternalStylesheet` (the JDK transformer implies both under the feature) and does not change the caller-supplied-factory constructor of `XSLTResourceStream`, per the ticket. Regression evidence: the new test fails on this branch without the source change (the canary is resolved into `<r>WICKET-XXE-CANARY-7f55</r>`) and passes with it, alongside `OutputTransformerContainerTest` (3/3). `mvn -Pfast -pl wicket-core -am test -Dtest=XsltTransformerXxeTest,OutputTransformerContainerTest -Dsurefire.failIfNoSpecifiedTests=false`. Local verification note: `wicket-9.x` CI runs OpenJDK 11 / Maven 3.8.7, and JDK 11 is not installed on this machine. Under JDK 17 / Maven 3.9.16 the unmodified `wicket-9.x` tip hits a JPMS compile error (`cannot access javax.servlet.http.HttpServletRequest` in `MultipartServletWebRequestImpl`) independently of this change, so the local test runs temporarily excluded `module-info.java` and restored it afterwards. This PR does not touch `module-info.java`, and the unmodified tree is expected to build normally on the line's JDK 11 CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
