dashorst opened a new pull request, #1692:
URL: https://github.com/apache/wicket/pull/1692

   Backport of #1684 and #1691 to `wicket-10.x`, for GitHub issues #1678 and 
#1690.
   
   - f5a725401d, cherry-picked from #1684: `slf4j-simple` gets test scope in 
the quickstart archetype, so a generated WAR no longer packages an SLF4J back 
end. Servers that bring their own back end, such as WildFly, no longer see two.
   - 02cc04779a, cherry-picked from #1691: `<useTestScope>true</useTestScope>` 
on the jetty-ee10-maven-plugin, so `mvn jetty:run` keeps a back end, plus a 
corrected comment on the dependency.
   
   Verified on this branch:
   - `mvn verify -pl archetypes/quickstart` passes, including the archetype 
integration test.
   - `mvn jetty:run` on the generated project logs `Started Wicket version 
10.12.0-SNAPSHOT in DEVELOPMENT mode`, and `/` returns 200.
   - The WAR contains `slf4j-api` and no back end.
   
   Release-note wording: a quickstart generated from 10.12.0 onwards no longer 
packages `slf4j-simple` in its WAR. When deploying to a container that has no 
SLF4J back end of its own (Tomcat, a standalone Jetty), add one as a runtime 
dependency. Projects generated earlier are not affected.
   
   Merge with a merge commit or rebase rather than squash, so that #1684 keeps 
its author.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to