Nexory commented on PR #1698: URL: https://github.com/apache/wicket/pull/1698#issuecomment-6331163901
Codecov flagged three partly covered branches in this patch, so I added a second commit that only adds tests. Production code is unchanged. The new tests cover remove(CHILD_SRC) without any frame-src, a frame-src value that copies another directive, and a frame-src value that copies the child-src of another configuration. In the last two cases remove(CHILD_SRC) keeps the value. The two copy cases are what pins the check in isCloneOf(): when I changed it to return true for every copy, both tests failed, and the test without a frame-src still passed. ContentSecurityPolicySettingsTest now runs 40 tests, all green. wicket-core-tests with the modules it builds from ran 2787 tests with 0 failed and 19 skipped, against 2779 with 0 failed and 19 skipped on master. With the coverage profile, the branches of remove() and isCloneOf() together go from 10 of 14 covered to 14 of 14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
