dashorst opened a new pull request, #1709: URL: https://github.com/apache/wicket/pull/1709
Part of #1708. `build-versions.py` writes the per-module versions that `release.sh` appends to `release.properties` for `release:prepare`. It now runs on Python 3 and takes its module list from the poms. The old script failed on every line that still releases. It was Python 2 behind `#!/usr/bin/python`, so where `python` is Python 3 `release.sh` stopped with a `SyntaxError`. Its module list came from the `<modules>` of the root pom and `wicket-native-websocket` only, with artifact IDs derived from directory names, so the modules under `wicket-experimental` were missing and `wicket-experimental` was listed twice under two wrong groupIds. The issue has the per-branch table. The script now walks the `<modules>` tree from the root pom and emits each module with the groupId and artifactId its pom declares, inheriting the groupId from `<parent>` where the pom has none. Adding or removing a module needs no change to the script. ## Review The only file is `build-versions.py`, one commit. The output format is unchanged, so `release.sh` needs no change. ## Risk Only release tooling changes; nothing in the build or the artifacts does. A module declared only inside a profile would also be emitted, since the script does not evaluate profiles; no branch has one. ## Tests - **master**: `./build-versions.py 11.0.0 11.1.0-SNAPSHOT` emits 34 modules, the same 34 as Maven's reactor build order (`mvn -o validate`), with `org.apache.wicket.experimental.wicket10` for `wicket-experimental` and `wicket-metrics`. - **Maintenance lines**: run against each branch's poms, the script emits 32 modules on `wicket-10.x` and `wicket-9.x` and 33 on `wicket-8.x`, each matching that branch's `<modules>` tree. Maven itself was not run on those branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
