Author: veithen
Date: Sun Jul 10 11:45:59 2011
New Revision: 1144839

URL: http://svn.apache.org/viewvc?rev=1144839&view=rev
Log:
OMNamespace#getNamespaceURI() never returns null. Removed this case so that 
Cobertura doesn't report incomplete branch coverage.

Modified:
    
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11HeaderImpl.java
    
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap12/SOAP12HeaderImpl.java
    
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11HeaderImpl.java
    
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12HeaderImpl.java

Modified: 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11HeaderImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11HeaderImpl.java?rev=1144839&r1=1144838&r2=1144839&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11HeaderImpl.java
 (original)
+++ 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11HeaderImpl.java
 Sun Jul 10 11:45:59 2011
@@ -56,7 +56,7 @@ public class SOAP11HeaderImpl extends SO
 
     public SOAPHeaderBlock addHeaderBlock(String localName, OMNamespace ns)
             throws OMException {
-        if (ns == null || ns.getNamespaceURI() == null || 
"".equals(ns.getNamespaceURI())) {
+        if (ns == null || ns.getNamespaceURI().length() == 0) {
             throw new OMException(
                     "All the SOAP Header blocks should be namespace 
qualified");
         }

Modified: 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap12/SOAP12HeaderImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap12/SOAP12HeaderImpl.java?rev=1144839&r1=1144838&r2=1144839&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap12/SOAP12HeaderImpl.java
 (original)
+++ 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap12/SOAP12HeaderImpl.java
 Sun Jul 10 11:45:59 2011
@@ -53,7 +53,7 @@ public class SOAP12HeaderImpl extends SO
     }
 
     public SOAPHeaderBlock addHeaderBlock(String localName, OMNamespace ns) 
throws OMException {
-        if (ns == null || ns.getNamespaceURI() == null || 
"".equals(ns.getNamespaceURI())) {
+        if (ns == null || ns.getNamespaceURI().length() == 0) {
             throw new OMException(
                     "All the SOAP Header blocks should be namespace 
qualified");
         }

Modified: 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11HeaderImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11HeaderImpl.java?rev=1144839&r1=1144838&r2=1144839&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11HeaderImpl.java
 (original)
+++ 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11HeaderImpl.java
 Sun Jul 10 11:45:59 2011
@@ -61,7 +61,7 @@ public class SOAP11HeaderImpl extends SO
     public SOAPHeaderBlock addHeaderBlock(String localName, OMNamespace ns)
             throws OMException {
 
-        if (ns == null || ns.getNamespaceURI() == null || 
"".equals(ns.getNamespaceURI())) {
+        if (ns == null || ns.getNamespaceURI().length() == 0) {
             throw new OMException(
                     "All the SOAP Header blocks should be namespace 
qualified");
         }

Modified: 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12HeaderImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12HeaderImpl.java?rev=1144839&r1=1144838&r2=1144839&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12HeaderImpl.java
 (original)
+++ 
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12HeaderImpl.java
 Sun Jul 10 11:45:59 2011
@@ -59,7 +59,7 @@ public class SOAP12HeaderImpl extends SO
     }
 
     public SOAPHeaderBlock addHeaderBlock(String localName, OMNamespace ns) 
throws OMException {
-        if (ns == null || ns.getNamespaceURI() == null || 
"".equals(ns.getNamespaceURI())) {
+        if (ns == null || ns.getNamespaceURI().length() == 0) {
             throw new OMException(
                     "All the SOAP Header blocks should be namespace 
qualified");
         }


Reply via email to