This is an automated email from the ASF dual-hosted git repository.
veithen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ws-axiom.git
The following commit(s) were added to refs/heads/master by this push:
new c500dd42d Remove dead addTestParameter() calls from SOAP test classes
c500dd42d is described below
commit c500dd42d12b3a92bc1f7bef2f7b0df41dd1fc37
Author: Andreas Veithen-Knowles <[email protected]>
AuthorDate: Tue Mar 24 00:01:20 2026 +0000
Remove dead addTestParameter() calls from SOAP test classes
The SOAP suite was already migrated to the MatrixTestNode framework, but
the leaf test class constructors still contained addTestParameter() calls
on 'this'. These are dead code since the new framework uses
ParameterBinding lambdas in SOAPTestSuite instead.
---
.../src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java | 1 -
.../axiom/ts/soap/body/FirstElementNameWithParserTestCase.java | 3 ---
.../ts/soap/factory/CreateSOAPElementWithoutParentTestCase.java | 2 --
.../apache/axiom/ts/soap/headerblock/BooleanAttributeTestCase.java | 1 -
.../main/java/org/apache/axiom/ts/soap/headerblock/TestClone.java | 1 -
.../main/java/org/apache/axiom/ts/soap/misc/GetSetChildTestCase.java | 5 -----
6 files changed, 13 deletions(-)
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java
index 202854568..be8a82099 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java
@@ -34,7 +34,6 @@ public abstract class SOAPTestCase extends AxiomTestCase {
public SOAPTestCase(OMMetaFactory metaFactory, SOAPSpec spec) {
super(metaFactory);
this.spec = spec;
- addTestParameter("spec", spec.getName());
}
@Override
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/body/FirstElementNameWithParserTestCase.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/body/FirstElementNameWithParserTestCase.java
index cff87d6c1..9b3b213ed 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/body/FirstElementNameWithParserTestCase.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/body/FirstElementNameWithParserTestCase.java
@@ -49,9 +49,6 @@ public abstract class FirstElementNameWithParserTestCase
extends SOAPTestCase {
OMMetaFactory metaFactory, SOAPSpec spec, QName qname, boolean
supportsOptimization) {
super(metaFactory, spec);
this.qname = qname;
- addTestParameter("prefix", qname.getPrefix());
- addTestParameter("uri", qname.getNamespaceURI());
- addTestParameter("localName", qname.getLocalPart());
this.supportsOptimization = supportsOptimization;
}
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/factory/CreateSOAPElementWithoutParentTestCase.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/factory/CreateSOAPElementWithoutParentTestCase.java
index 560b40ce4..8861fc741 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/factory/CreateSOAPElementWithoutParentTestCase.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/factory/CreateSOAPElementWithoutParentTestCase.java
@@ -27,7 +27,6 @@ import org.apache.axiom.om.OMMetaFactory;
import org.apache.axiom.om.OMNamespace;
import org.apache.axiom.soap.SOAPConstants;
import org.apache.axiom.ts.soap.SOAPElementType;
-import org.apache.axiom.ts.soap.SOAPElementTypeAdapter;
import org.apache.axiom.ts.soap.SOAPSpec;
import org.apache.axiom.ts.soap.SOAPTestCase;
@@ -38,7 +37,6 @@ public abstract class CreateSOAPElementWithoutParentTestCase
extends SOAPTestCas
OMMetaFactory metaFactory, SOAPSpec spec, SOAPElementType type) {
super(metaFactory, spec);
this.type = type;
- type.getAdapter(SOAPElementTypeAdapter.class).addTestParameters(this);
}
@Override
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/BooleanAttributeTestCase.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/BooleanAttributeTestCase.java
index 10c2bab89..6dce8bf25 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/BooleanAttributeTestCase.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/BooleanAttributeTestCase.java
@@ -30,6 +30,5 @@ public abstract class BooleanAttributeTestCase extends
SOAPTestCase {
OMMetaFactory metaFactory, SOAPSpec spec, HeaderBlockAttribute
attribute) {
super(metaFactory, spec);
this.attribute = attribute;
- addTestParameter("attribute", attribute.getName(spec));
}
}
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestClone.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestClone.java
index 05d1bdd6e..4556301c2 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestClone.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/headerblock/TestClone.java
@@ -42,7 +42,6 @@ public class TestClone extends SOAPTestCase {
@Named("processed") @Nullable Boolean processed) {
super(metaFactory, spec);
this.processed = processed;
- addTestParameter("processed", String.valueOf(processed));
}
private void checkProcessed(SOAPHeader clonedHeader, SOAPHeaderBlock
orgHeaderBlock) {
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/misc/GetSetChildTestCase.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/misc/GetSetChildTestCase.java
index 14fe9a24b..42f12b186 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/misc/GetSetChildTestCase.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/misc/GetSetChildTestCase.java
@@ -37,11 +37,6 @@ public abstract class GetSetChildTestCase extends
SOAPTestCase {
super(metaFactory, spec);
this.type = type;
this.childType = childType;
- addTestParameter(
- "type",
type.getAdapter(SOAPElementTypeAdapter.class).getType().getSimpleName());
- addTestParameter(
- "childType",
-
childType.getAdapter(SOAPElementTypeAdapter.class).getType().getSimpleName());
}
@Override
