(ws-axiom) branch master updated: Use pattern variables in dom-mixins to satisfy Error Prone 2.51.0

[veithen.apache.org via commits]

This is an automated email from the ASF dual-hosted git repository.

veithen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ws-axiom.git


The following commit(s) were added to refs/heads/master by this push:
     new ce175daaf Use pattern variables in dom-mixins to satisfy Error Prone 
2.51.0
ce175daaf is described below

commit ce175daaf9d43068d8b3589cd73fc8d500e2d5fa
Author: Claude <nore...@anthropic.com>
AuthorDate: Sat Oct 31 11:50:11 2026 +0000

    Use pattern variables in dom-mixins to satisfy Error Prone 2.51.0
    
    Error Prone 2.51.0 extends the PatternMatchingInstanceof check to flag
    redundant casts where an instanceof already introduces a pattern
    variable. Use the existing pattern variables instead of casting again.
    
    Co-Authored-By: Claude Opus 5.5 <nore...@anthropic.com>
    Claude-Session: https://claude.ai/code/session_01F8HaVVy7D4ZfJZPwsobS7X
---
 .../main/java/org/apache/axiom/dom/impl/mixin/DOMDocumentMixin.java | 2 +-
 .../java/org/apache/axiom/dom/impl/mixin/DOMParentNodeMixin.java    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMDocumentMixin.java
 
b/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMDocumentMixin.java
index d0e40d1ee..2dea72d6c 100644
--- 
a/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMDocumentMixin.java
+++ 
b/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMDocumentMixin.java
@@ -367,7 +367,7 @@ public abstract class DOMDocumentMixin implements 
DOMDocument {
             localName = qualifiedName.substring(i + 1);
         }
         namespaceURI = NSUtil.normalizeNamespaceURI(namespaceURI);
-        switch (((DOMNode) node).coreGetNodeType()) {
+        switch (domNode.coreGetNodeType()) {
             case NS_AWARE_ELEMENT -> {
                 NSUtil.validateNamespace(namespaceURI, prefix);
                 ((DOMNSAwareElement) node).coreSetName(namespaceURI, 
localName, prefix);
diff --git 
a/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMParentNodeMixin.java
 
b/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMParentNodeMixin.java
index 647b9768b..20ad25c36 100644
--- 
a/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMParentNodeMixin.java
+++ 
b/mixins/dom-mixins/src/main/java/org/apache/axiom/dom/impl/mixin/DOMParentNodeMixin.java
@@ -122,7 +122,7 @@ public abstract class DOMParentNodeMixin implements 
DOMParentNode {
             if (!coreHasSameOwnerDocument(newDomChild)) {
                 throw newDOMException(DOMException.WRONG_DOCUMENT_ERR);
             }
-            checkNewChild0((DOMNode) newChild);
+            checkNewChild0(newDomChild);
         } else {
             throw newDOMException(DOMException.WRONG_DOCUMENT_ERR);
         }
@@ -159,9 +159,9 @@ public abstract class DOMParentNodeMixin implements 
DOMParentNode {
                 }
                 checkNewChild(newChild);
                 if (newChild instanceof CoreChildNode newChildNode) {
-                    ((CoreChildNode) 
refChild).coreInsertSiblingBefore(newChildNode);
+                    childNode.coreInsertSiblingBefore(newChildNode);
                 } else if (newChild instanceof CoreDocumentFragment 
documentFragment) {
-                    ((CoreChildNode) 
refChild).coreInsertSiblingsBefore(documentFragment);
+                    childNode.coreInsertSiblingsBefore(documentFragment);
                 } else {
                     throw newDOMException(DOMException.HIERARCHY_REQUEST_ERR);
                 }