ashvina commented on code in PR #399:
URL: https://github.com/apache/incubator-xtable/pull/399#discussion_r1540419565
##########
api/src/main/java/org/apache/xtable/model/storage/OneDataFilesDiff.java:
##########
@@ -31,7 +31,7 @@
@Value
@EqualsAndHashCode(callSuper = true)
@SuperBuilder
-public class OneDataFilesDiff extends DataFilesDiff<OneDataFile, OneDataFile> {
+public class OneDataFilesDiff extends DataFilesDiff<InternalDataFile,
InternalDataFile> {
Review Comment:
My understanding is that the "internal" prefix will be used selectively, in
cases where the class name collision across packages is high. DataFileDiff is
not a common class name. Accordingly, I have renamed the base file, old
DataFilesDiff -> new FilesDiff, and renamed OneDataFilesDiff to DataFilesDiff.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
