vinishjail97 commented on code in PR #458: URL: https://github.com/apache/incubator-xtable/pull/458#discussion_r1626998717
########## website/docs/hms.md: ########## @@ -127,6 +127,16 @@ cd $HUDI_HOME/hudi-sync/hudi-hive-sync --table <tableName> ``` +```shell md title="example for s3 with HMS" +./run_sync_tool.sh \ +--metastore-uris 'thrift://hive-metastore:9083' \ +--partitioned-by city \ +--base-path 's3a://warehouse/people' \ +--database hudi_db \ Review Comment: Parameterise these similar to the jdbc command ? ########## website/docs/hms.md: ########## @@ -127,6 +127,16 @@ cd $HUDI_HOME/hudi-sync/hudi-hive-sync --table <tableName> ``` +```shell md title="example for s3 with HMS" +./run_sync_tool.sh \ +--metastore-uris 'thrift://hive-metastore:9083' \ +--partitioned-by city \ Review Comment: `<partition_field>` ? ########## website/docs/hms.md: ########## @@ -218,6 +228,38 @@ using query engines like `Presto` and/or `Trino`. Check out the guides for query SELECT * FROM iceberg_db.<table_name>; ``` +```sql md title="sql for Iceberg, Hudi and Delta Lake in S3" +select * from hudi.hudi_db.people; +select * from delta.delta_db.people; +select * from iceberg.iceberg_db.people; +``` + +In the example docker image, you can find the catalog configurations in `/etc/trino/catalog` +```shell md title="Trino Catalog with S3" +trino@trino:/$ cat /etc/trino/catalog/hudi.properties Review Comment: Do we really need the cat shell command and this statement should suffice ? `In the example docker image, you can find the catalog configurations..` ########## website/docs/hms.md: ########## @@ -127,6 +127,16 @@ cd $HUDI_HOME/hudi-sync/hudi-hive-sync --table <tableName> ``` +```shell md title="example for s3 with HMS" Review Comment: Let's keep move this up and move the JDBC command below the HMS one. For the jdbc one, we can call out it's the old way of syncing to hive. ########## website/docs/hms.md: ########## @@ -218,6 +228,38 @@ using query engines like `Presto` and/or `Trino`. Check out the guides for query SELECT * FROM iceberg_db.<table_name>; ``` +```sql md title="sql for Iceberg, Hudi and Delta Lake in S3" +select * from hudi.hudi_db.people; +select * from delta.delta_db.people; +select * from iceberg.iceberg_db.people; +``` + +In the example docker image, you can find the catalog configurations in `/etc/trino/catalog` +```shell md title="Trino Catalog with S3" +trino@trino:/$ cat /etc/trino/catalog/hudi.properties Review Comment: Can we add this here https://github.com/apache/incubator-xtable/tree/main/demo/trino/catalog/hudi.properties ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
