the-other-tim-brown commented on code in PR #499: URL: https://github.com/apache/incubator-xtable/pull/499#discussion_r1704394536
########## README.md: ########## @@ -117,6 +117,19 @@ The custom hadoop configurations can be passed in with the `--hadoopConfig [cust The config in custom hadoop config file will override the default hadoop configurations. For an example of a custom hadoop config file, see [hadoop.xml](https://xtable.apache.org/docs/fabric#step-2-translate-source-table-to-delta-lake-format-using-apache-xtable-incubating). +# Running using docker + +In order to run using docker, you must mount the config files on the container. The follow commands how to: + +``` +docker run \ + -v ./xtable/config.yml:/xtable/config.yml \ + -v ./xtable/core-site.xml:/xtable/core-site.xml \ + -v ./xtable/catalog.yml:/xtable/catalog.yml \ + registry.gitlab.com/pedalin/xtable-docker-image:4420d2b6 \ Review Comment: Since this isn't hosted by apache, should we just include instructions on how to build the image and then have this be something like "path to image"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
