the-other-tim-brown commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1721110508
##########
xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java:
##########
@@ -435,6 +435,11 @@ private Schema fromInternalSchema(InternalSchema
internalSchema, String currentP
Schema.createFixed(
internalSchema.getName(), internalSchema.getComment(), null,
fixedSize),
internalSchema);
+ case UUID:
+ // Convert to fixed 16-byte array since Avro does not support UUID
natively
+ return finalizeSchema(
+ Schema.createFixed(internalSchema.getName(),
internalSchema.getComment(), null, 16),
+ internalSchema);
Review Comment:
Nothing else is coming to mind. For partitions, we only support the
year/month/day/hour and identity transforms from Iceberg current so those
partition functions would just pass through the value if I'm remembering
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
