rangareddy opened a new pull request, #539:
URL: https://github.com/apache/incubator-xtable/pull/539

   ## *Important Read*
   
   This pull request aims to address issues 
[#532](https://github.com/apache/incubator-xtable/issues/532)
   
   ## What is the purpose of the pull request
   
   Adding the DISCLAIMER file to META-INF folders in all jars.
   
   ## Brief change log
   
   * Added the `<resourceBundles>` to the `maven-remote-resources-plugin` 
plugin in pom.xml file.
   
   ```xml
   <resourceBundles>
        
<resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle>
        
<resourceBundle>org.apache.apache.resources:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT</resourceBundle>
   </resourceBundles>
   ```
   
   * Added `DISCLAIMER` file
   
   ## Verify this pull request
   
   Run `$ mvn clean install -DskipTests -U` locally and extract the jars and 
verify `META-INF` folder.
   
   **META-INF folder before this PR:**
   
   ```sh
   % ls -ltr META-INF 
   total 48
   drwxr-xr-x  3 rangareddy  staff     96 Jul  4 18:52 maven
   -rw-r--r--  1 rangareddy  staff    176 Jul  4 18:52 NOTICE
   -rw-r--r--  1 rangareddy  staff    341 Jul  4 18:52 MANIFEST.MF
   -rw-r--r--  1 rangareddy  staff  11358 Jul  4 18:52 LICENSE
   -rw-r--r--  1 rangareddy  staff   1942 Jul  4 18:52 DEPENDENCIES
   ```
   
   **META-INF folder after this PR:**
   
   ```sh
   % ls -ltr META-INF
   total 56
   drwxr-xr-x  3 rangareddy  staff     96 Jul  4 18:52 maven
   -rw-r--r--  1 rangareddy  staff    179 Jul  4 18:52 NOTICE
   -rw-r--r--  1 rangareddy  staff    341 Jul  4 18:52 MANIFEST.MF
   -rw-r--r--  1 rangareddy  staff  11358 Jul  4 18:52 LICENSE
   -rw-r--r--  1 rangareddy  staff    559 Jul  4 18:52 DISCLAIMER
   -rw-r--r--  1 rangareddy  staff   1942 Jul  4 18:52 DEPENDENCIES
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to