danielhumanmod commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1770785164
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -103,6 +109,7 @@ public class ITConversionController {
private static JavaSparkContext jsc;
private static SparkSession sparkSession;
+ private static final ObjectMapper objectMapper = new ObjectMapper();
Review Comment:
> use `UPPER_UNDERSCORE` when defining constants and move this up to line
109 to group with the `DATE_FORMAT`
Done! Thanks for the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
