vinishjail97 commented on code in PR #591:
URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1883134988
##########
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalTable.java:
##########
@@ -38,6 +40,8 @@ class ExternalTable {
protected final @NonNull String formatName;
/** The path to the root of the table or the metadata directory depending on
the format */
protected final @NonNull String basePath;
+ /** The path to the data files, defaults to the metadataPath */
+ protected final @NonNull String dataPath;
Review Comment:
I have reverted this, didn't make much sense. The conversion from
TargetTable to SourceTable object is used for reading the latest version of the
InternalTable during target table's catalog sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
