vinishjail97 commented on code in PR #599: URL: https://github.com/apache/incubator-xtable/pull/599#discussion_r1884671092
########## xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogConversionSource.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xtable.catalog.glue; + +import java.util.Properties; + +import org.apache.hadoop.conf.Configuration; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import com.google.common.base.Strings; + +import org.apache.xtable.conversion.SourceCatalog; +import org.apache.xtable.conversion.SourceTable; +import org.apache.xtable.model.catalog.CatalogTableIdentifier; +import org.apache.xtable.spi.extractor.CatalogConversionSource; + +import software.amazon.awssdk.services.glue.GlueClient; +import software.amazon.awssdk.services.glue.model.GetTableRequest; +import software.amazon.awssdk.services.glue.model.GetTableResponse; +import software.amazon.awssdk.services.glue.model.Table; + +public class GlueCatalogConversionSource implements CatalogConversionSource { Review Comment: I got rid of SourceCatalog and TargetCatalog, simplified the catalog configuration, now I think it's just adding this function `SourceTable getSourceTable(CatalogTableIdentifier tableIdentifier)` to the impl class which implements this. Regardless I will keep the config for `sourceCatalogConversionImplClass` available in OSS for users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
