the-other-tim-brown commented on code in PR #596:
URL: https://github.com/apache/incubator-xtable/pull/596#discussion_r1890454695
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaStatsExtractor.java:
##########
@@ -239,13 +265,34 @@ private Map<String, Object> flattenStatMap(Map<String,
Object> statMap) {
return result;
}
+ /**
+ * Returns the names of all unsupported stats that have been discovered
during the parsing of
+ * Delta Lake stats.
+ *
+ * @return set of unsupported stats
+ */
+ @VisibleForTesting
+ public static Set<String> getUnsupportedStats() {
Review Comment:
let's make this package private if it is just for testing
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaStatsExtractor.java:
##########
@@ -74,9 +80,13 @@ public class DeltaStatsExtractor {
private static final DeltaStatsExtractor INSTANCE = new
DeltaStatsExtractor();
- private static final String PATH_DELIMITER = "\\.";
private static final ObjectMapper MAPPER = new ObjectMapper();
+ /* this data structure collects type names of all unrecognized Delta Lake
stats. For instance
+ data file stats in presence of delete vectors would contain 'tightBounds'
stat which is
+ currently not handled by XTable */
+ private static final Set<String> unsupportedStats = new HashSet<>();
Review Comment:
Should this be an instance variable instead? if not, let's follow the naming
conventions and use `UPPER_UNDERSCORE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
