the-other-tim-brown commented on code in PR #604: URL: https://github.com/apache/incubator-xtable/pull/604#discussion_r1893264329
########## rfc/template.md: ########## @@ -0,0 +1,55 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +# RFC-[number]: [Title] + +## Proposers + +- @<proposer1 github username> +- @<proposer2 github username> + +## Approvers +- @<approver1 github username> +- @<approver2 github username> + +## Status + +GH Feature Request: <link to umbrella JIRA> + +> Please keep the status updated in `rfc/README.md`. + +## Abstract + +Describe the problem you are trying to solve and a brief description of why it’s needed. + +## Background +Introduce any background context which is relevant or necessary to understand the feature and design choices. + +## Implementation +Describe the new thing you want to do in appropriate detail, how it fits into the project architecture.<br> +Provide a detailed description of how you intend to implement this feature, this may be fairly extensive and have large subsections of its own or it may be a few sentences.<br> +Use judgement based on the scope of the change. Review Comment: Use judgement for what? Is this meant for the line above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
