vinishjail97 commented on code in PR #591:
URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1898182771
##########
xtable-core/src/test/java/org/apache/xtable/TestSparkDeltaTable.java:
##########
@@ -134,15 +134,7 @@ public void upsertRows(List<Row> upsertRows) {
}
@SneakyThrows
- @Override
public void deleteRows(List<Row> deleteRows) {
- String idsToDelete =
- deleteRows.stream().map(row ->
row.get(0).toString()).collect(Collectors.joining(", "));
- deltaTable.delete("id in (" + idsToDelete + ")");
- }
-
- @SneakyThrows
- public void mergeDeleteRows(List<Row> deleteRows) {
Review Comment:
yeah this was a rebase error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
