the-other-tim-brown commented on code in PR #623:
URL: https://github.com/apache/incubator-xtable/pull/623#discussion_r1919047104
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaStatsExtractor.java:
##########
@@ -223,6 +223,15 @@ public List<ColumnStat> getColumnStatsForFile(AddFile
addFile, List<InternalFiel
}
}
+ public long getNumRecords(AddFile addFile) {
Review Comment:
Instead of parsing the stats twice, is there a way we can include this with
the column stats output of `getColumnStatsForFile`? Maybe we can have some
wrapper that wraps the count with the formatted stats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
