vamsikarnika commented on code in PR #639:
URL: https://github.com/apache/incubator-xtable/pull/639#discussion_r1942725195
##########
xtable-hive-metastore/src/main/java/org/apache/xtable/hms/HMSCatalogTableBuilderFactory.java:
##########
@@ -40,10 +41,12 @@
public class HMSCatalogTableBuilderFactory {
public static CatalogTableBuilder<Table, Table> getTableBuilder(
- String tableFormat, Configuration configuration) {
+ String tableFormat, HMSCatalogConfig hmsCatalogConfig, Configuration
configuration) {
switch (tableFormat) {
case TableFormat.ICEBERG:
return new IcebergHMSCatalogTableBuilder(configuration);
+ case TableFormat.HUDI:
+ return new HudiHMSCatalogTableBuilder(hmsCatalogConfig, configuration);
Review Comment:
HudiHMSCatalogTableBuilder needs to access hmsCatalogConfig for building
table properties. It uses schemaLengthThreshold config to generate the table
properties accordngly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
