the-other-tim-brown commented on code in PR #637:
URL: https://github.com/apache/incubator-xtable/pull/637#discussion_r1945015596
##########
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java:
##########
@@ -231,4 +233,42 @@ protected String toTypeString(InternalSchema fieldSchema,
String tableFormat) {
protected static String getColumnProperty(String tableFormat, String
property) {
return String.format("%s.%s", tableFormat.toLowerCase(Locale.ENGLISH),
property);
}
+
+ @VisibleForTesting
Review Comment:
This isn't just visible for testing anymore right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
