the-other-tim-brown commented on code in PR #630:
URL: https://github.com/apache/incubator-xtable/pull/630#discussion_r1949570427
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -123,7 +123,10 @@ public InternalTable getTable(Snapshot snapshot) {
return InternalTable.builder()
.tableFormat(TableFormat.ICEBERG)
.basePath(iceTable.location())
- .name(iceTable.name())
+ .name(
Review Comment:
Can you add a quick inline comment to explain that if the table name is not
specified, Iceberg will default to the path so we use the name from the source
config? It will be helpful for future developers to know the context when they
come across this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
