vinishjail97 commented on code in PR #639:
URL: https://github.com/apache/incubator-xtable/pull/639#discussion_r1952105985
##########
xtable-core/src/main/java/org/apache/xtable/catalog/CatalogUtils.java:
##########
@@ -35,4 +44,24 @@ public static HierarchicalTableIdentifier
toHierarchicalTableIdentifier(
throw new IllegalArgumentException(
"Invalid tableIdentifier implementation: " +
tableIdentifier.getClass().getName());
}
+
+ public static Optional<PartitionSyncTool> getPartitionSyncTool(
+ String tableFormat,
+ String partitionValueExtractorClass,
+ CatalogPartitionSyncOperations catalogPartitionSyncOperations,
+ Configuration configuration) {
+
+ if (partitionValueExtractorClass.isEmpty()) {
+ return Optional.empty();
+ }
+
+ if (tableFormat.equals(TableFormat.HUDI)) {
Review Comment:
Can you add a comment why it's required only for hudi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
