vamsikarnika commented on code in PR #648:
URL: https://github.com/apache/incubator-xtable/pull/648#discussion_r1961260262
##########
xtable-hive-metastore/src/main/java/org/apache/xtable/hms/HMSCatalogSyncClient.java:
##########
@@ -70,12 +75,25 @@ public HMSCatalogSyncClient(
HMSCatalogConfig hmsCatalogConfig,
Configuration configuration,
IMetaStoreClient metaStoreClient,
- CatalogTableBuilder tableBuilder) {
+ CatalogTableBuilder tableBuilder,
+ Optional<CatalogPartitionSyncTool> partitionSyncTool) {
this.catalogConfig = catalogConfig;
this.hmsCatalogConfig = hmsCatalogConfig;
this.configuration = configuration;
this.metaStoreClient = metaStoreClient;
this.tableBuilder = tableBuilder;
+ this.partitionSyncTool = partitionSyncTool;
+ }
+
+ private Optional<CatalogPartitionSyncTool> getPartitionSyncTool(String
tableFormat) {
+ String partitionValueExtractorClass =
hmsCatalogConfig.getPartitionExtractorClass();
+ CatalogPartitionSyncOperations hmsCatalogPartitionSyncOperations =
+ new HMSCatalogPartitionSyncOperations(metaStoreClient,
hmsCatalogConfig);
Review Comment:
Yes, this is only used from _init method now. I've moved it to the same
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
