piyushdubey commented on code in PR #661:
URL: https://github.com/apache/incubator-xtable/pull/661#discussion_r1984162981
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionSource.java:
##########
@@ -129,10 +130,10 @@ public TableChange getTableChangeForCommit(Long
versionNumber) {
DeltaPartitionExtractor.getInstance(),
DeltaStatsExtractor.getInstance());
addedFiles.put(dataFile.getPhysicalPath(), dataFile);
- String deleteVectorPath =
- actionsConverter.extractDeletionVectorFile(snapshotAtVersion,
(AddFile) action);
- if (deleteVectorPath != null) {
- deletionVectors.add(deleteVectorPath);
+ InternalDeletionVector deletionVector =
+ actionsConverter.extractDeletionVector(snapshotAtVersion,
(AddFile) action);
+ if (deletionVector != null) {
+ deletionVectors.put(deletionVector.dataFilePath(), deletionVector);
Review Comment:
Makes sense. I see on line 168, you are concatenating the deletion vectors
to the Internal files, which will not add dv and data file both without
skipping.
Thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
