the-other-tim-brown commented on code in PR #647:
URL: https://github.com/apache/incubator-xtable/pull/647#discussion_r2023648267


##########
xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java:
##########
@@ -160,11 +160,13 @@ private InternalSchema toInternalSchema(
           metadata.put(
               InternalSchema.MetadataKey.TIMESTAMP_PRECISION, 
InternalSchema.MetadataValue.MICROS);
         } else if (logicalType instanceof LogicalTypes.LocalTimestampMillis) {
-          newDataType = InternalType.TIMESTAMP_NTZ;
+          // TODO: Hudi 0.x writes INT64 in parquet, TimestampNTZType support 
added in 1.x

Review Comment:
   Can you add a new issue tracking this and the below TODO and add the link in 
the comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to