the-other-tim-brown commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2052912672
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -52,4 +52,21 @@ public class InternalDataFile extends InternalFile {
@Builder.Default @NonNull List<ColumnStat> columnStats =
Collections.emptyList();
// last modified time in millis since epoch
long lastModified;
+ public static InternalDataFileBuilder builderFrom(InternalDataFile dataFile)
{
+ return dataFile.toBuilder();
+ }
+
+ public boolean equals(InternalDataFile obj2) {
Review Comment:
The implementation here does not assert that the lists are the same size so
you do not know whether there are more entries in obj2's stats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
