Monilnarang opened a new pull request, #703: URL: https://github.com/apache/incubator-xtable/pull/703
## What is the purpose of the pull request This pull request improves both the tests in `TestHudiInstantUtils` by refactoring them into parameterised unit tests and also adding more test cases to enhance testing logic. Elaboration: * The same method calls (parseFromInstantTime & convertInstantToCommit) are repeated with different inputs, making the test harder to maintain and extend. When a test fails, JUnit only shows which type of assertion failed, but not which specific input caused the failure. Adding new test cases requires copying and pasting another Assertions.assertEquals(...) statement instead of simply adding new data. ## Brief change log - *Parameterised tests: `testParseCommitTimeToInstant` & `testInstantToCommit`* - *Added more test cases as value sets to above parameterised tests* ## Verify this pull request Below are the before and after unit test run reports: Below changes: <img width="365" alt="Screenshot 2025-04-24 at 11 08 53 AM" src="https://github.com/user-attachments/assets/d4b8e193-2fae-4360-b52c-628cce577f3c"; /> After changes: <img width="462" alt="Screenshot 2025-04-24 at 11 09 18 AM" src="https://github.com/user-attachments/assets/7f82be7d-5b56-4d7f-8b76-a12a05e28d6a"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
