unical1988 commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2059359308
##########
xtable-api/src/main/java/org/apache/xtable/model/stat/ColumnStat.java:
##########
@@ -31,9 +33,20 @@
@Value
@Builder(toBuilder = true)
public class ColumnStat {
- InternalField field;
- Range range;
- long numNulls;
- long numValues;
- long totalSize;
+ InternalField field;
+ Range range;
+ long numNulls;
+ long numValues;
+ long totalSize;
+
+ public boolean equals(ColumnStat colStat) {
Review Comment:
It seems you are right about the equals() the test still passed even after
removing the custom equals()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
