unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2299786638
##########
xtable-core/src/main/java/org/apache/xtable/parquet/ParquetSchemaExtractor.java:
##########
@@ -295,15 +298,23 @@ public InternalSchema toInternalSchema(Type schema,
String parentPath) {
.fieldId(fieldId == null ? null : fieldId.intValue())
.build());
}
- if (currentRepetition != Repetition.REPEATED
- && schema.asGroupType().getName() != "list"
+ // RECORD Type (non-nullable elements)
+ if (schema.asGroupType().getName() != "list"
&& !Arrays.asList("key_value",
"map").contains(schema.asGroupType().getName())) {
return InternalSchema.builder()
.name(schema.getName())
.comment(null)
+ // .recordKeyFields(subFields) // necessary for Hudi metadata
.dataType(InternalType.RECORD)
.fields(subFields)
- .isNullable(isNullable(schema.asGroupType()))
+ .isNullable(
+ isNullable(schema.asGroupType())) // false
isNullable(schema.asGroupType()) (TODO causing
Review Comment:
It seems indeed that this requires special handling in the case of passed
schema (record)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
