mikedias commented on code in PR #742: URL: https://github.com/apache/incubator-xtable/pull/742#discussion_r2331953293
########## xtable-core/src/main/java/org/apache/xtable/paimon/PaimonSchemaExtractor.java: ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xtable.paimon; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; + +import org.apache.paimon.schema.TableSchema; +import org.apache.paimon.types.*; + +import org.apache.xtable.exception.NotSupportedException; +import org.apache.xtable.model.schema.InternalField; +import org.apache.xtable.model.schema.InternalSchema; +import org.apache.xtable.model.schema.InternalType; +import org.apache.xtable.schema.SchemaUtils; + +/** Converts Paimon RowType to XTable InternalSchema. */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class PaimonSchemaExtractor { Review Comment: Thanks @the-other-tim-brown, that was a good insight! I've added the special fields based on `org.apache.paimon.table.SpecialFields` helper and now the InternalSchema matches the parquet files. <img width="521" height="293" alt="image" src="https://github.com/user-attachments/assets/d5938820-1268-4cd3-a12a-d2d49cebb5e8"; /> <img width="1291" height="834" alt="image" src="https://github.com/user-attachments/assets/64ec0f4c-7fab-4d66-9d39-ddaab3ad344d"; /> with that, the error changed to ``` class org.apache.iceberg.shaded.org.apache.arrow.vector.VarCharVector cannot be cast to class org.apache.iceberg.shaded.org.apache.arrow.vector.BitVector ``` This indicates that it's still the same class of problem, but it also indicates that the order of fields here matters for the iceberg reader. I've tried sorting by `name` and `fieldId` but I'm still getting variations of the same problem... :( Any more ideas? 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
