the-other-tim-brown commented on code in PR #749:
URL: https://github.com/apache/incubator-xtable/pull/749#discussion_r2412268925
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergSync.java:
##########
@@ -170,9 +170,9 @@ public class TestIcebergSync {
.build();
private final Schema icebergSchema =
new Schema(
- Types.NestedField.required(1, "timestamp_field",
Types.TimestampType.withoutZone()),
Review Comment:
This is just to prove out that the field numbering matches what is provided.
Currently the numbers are reassigned when the table is first created.
This can impact existing tables if the schema field IDs are currently wrong
but I think that would also imply that existing table is in a broken state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
