the-other-tim-brown commented on code in PR #729:
URL: https://github.com/apache/incubator-xtable/pull/729#discussion_r2557245771
##########
xtable-core/pom.xml:
##########
@@ -110,6 +110,20 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.delta</groupId>
+ <artifactId>delta-kernel-api</artifactId>
+ <version>${delta.kernel.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.delta</groupId>
+ <artifactId>delta-kernel-defaults</artifactId>
+ <version>${delta.kernel.version}</version>
Review Comment:
You should add the dependencies under the `dependencyManagement` section.
This enforces consistent versions throughout the project instead of letting
each module declare its own version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
